feat: remove core from dependencies #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -6,10 +6,7 @@ | |||
| "sourceType": "module" | |||
| }, | |||
| "plugins": ["@typescript-eslint", "jsdoc", "eslint-plugin-header"], | |||
| "extends": [ | |||
| "plugin:@typescript-eslint/recommended", | |||
| "plugin:prettier/recommended" | |||
There was a problem hiding this comment.
I found out that with the "plugin:prettier/recommended" there will be a conflict of linting with auto-save and prettier. Given that it will lint with prettier when push, there is no need to add this check with conflict.
gbockus-sf
changed the title
peternhale
requested changes
Jul 30, 2024
src/utils/createUtil.ts
Outdated
| import { nls } from '../i18n'; | ||
|
|
||
| /* tslint:disable:no-unused-expression */ | ||
|
|
||
| export class CreateUtil { | ||
| private static SFDX_STATE_FOLDER = '.sfdx'; |
There was a problem hiding this comment.
I would prefer the logic for DIR be moved to src/service/gitRepoUtils.ts. It is only used in one place.
src/utils/createUtil.ts
Outdated
| /** | ||
| * The full system path to the preferred global state folder | ||
| */ | ||
| public static get DIR(): string { |
There was a problem hiding this comment.
move to src/service/gitRepoUtils.ts
peternhale
approved these changes
Jul 30, 2024
mingxuanzhangsfdx
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR removes
@salesforce/corefrom dependencies, reduces the total size of the library.What issues does this PR fix or reference?
@W-16301500@